Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd ansible-release: include artifact URL in PR body #377

Merged
merged 2 commits into from Mar 27, 2024
Merged

Conversation

gotmax23
Copy link
Contributor

This exposes the release artifact download URL in the PR body so we can access it while reviewing the release PR.

This exposes the release artifact download URL in the PR body so we can
access it while reviewing the release PR.
@gotmax23
Copy link
Contributor Author

@gotmax23 gotmax23 marked this pull request as draft February 27, 2024 19:00
@webknjaz
Copy link
Member

Checked that the URL works but there an escaped LF that has to be dealt with..

Co-authored-by: Felix Fontein <felix@fontein.de>
@gotmax23
Copy link
Contributor Author

@gotmax23 gotmax23 marked this pull request as ready for review February 27, 2024 19:28
@gotmax23
Copy link
Contributor Author

Ready for review

@webknjaz
Copy link
Member

@gotmax23 could you also put the PR and artifact URLs into the job summary?

@gotmax23
Copy link
Contributor Author

The artifacts already show up in the summary but only after the entire workflow has finished. This way, the link is available during the PR review phase.

@webknjaz
Copy link
Member

@gotmax23 totally. I'm just asking for the job summary output additionally. This way, it's possible to see this information on that page too. Without having to go to the PR and then to the artifact. I don't think it's harmful to have the links in two places.

@gotmax23
Copy link
Contributor Author

I guess I don't know exactly what you mean. Are you referring to, for example, https://github.com/ansible-community/ansible-build-data/actions/runs/8067689405 or is there some other GHA "summary" feature that I don't know about?

@webknjaz
Copy link
Member

Random repo example: https://github.com/pyOpenSci/pyosMeta/actions/runs/8058291379#summary-22010849191 — this is a place where you can output markdown attached to workflow runs. Each job can write there and would get its own widget.

https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/

@gotmax23
Copy link
Contributor Author

I'll merge this for today's release. We can handle the summary part separately.

@gotmax23 gotmax23 merged commit de505a1 into main Mar 27, 2024
4 of 6 checks passed
@gotmax23 gotmax23 deleted the show-url branch March 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants