feat(eslint-config): added @html-eslint/eslint-plugin to the html plugin, improved the prettier console log output

Signed-off-by: prisis <d.bannert@anolilab.de>

Author: prisis

packages/eslint-config/package.json

@@ -66,6 +66,8 @@
     },
     "dependencies": {
         "@anolilab/package-json-utils": "1.3.0",
+        "@html-eslint/eslint-plugin": "^0.19.0",
+        "@html-eslint/parser": "^0.19.0",
         "@rushstack/eslint-patch": "^1.3.1",
         "@rushstack/eslint-plugin-security": "^0.6.0",
         "@typescript-eslint/eslint-plugin": ">=5.55.0",

packages/eslint-config/src/config/plugins/babel.ts

@@ -2,7 +2,6 @@ import { hasAnyDep } from "@anolilab/package-json-utils";
 import type { Linter } from "eslint";
 
 import createConfig from "../../utils/create-config";
-import { consoleLog } from "../../utils/loggers";
 import bestPracticesConfig from "../best-practices";
 import errorsConfig from "../errors";
 import styleConfig from "../style";
@@ -18,13 +17,6 @@ if (
         peerDeps: false,
     })
 ) {
-    // Workaround VS Code trying to run this file twice!
-    if (!global.hasAnolilabEsLintConfigBabelPrettier) {
-        global.hasAnolilabEsLintConfigBabelPrettier = true;
-
-        consoleLog("\nFound prettier as dependency, disabling some rules to fix wrong behavior of the rule with eslint and prettier");
-    }
-
     prettierRules = {
         "babel/quotes": 0,
 

packages/eslint-config/src/config/plugins/html.ts

@@ -1,7 +1,52 @@
+import { hasAnyDep } from "@anolilab/package-json-utils";
 import type { Linter } from "eslint";
 
+import styleConfig from "../style";
+
+const styleRules = styleConfig.rules as Linter.RulesRecord;
+
+let hasPrettier = false;
+
+let prettierRules: Linter.RulesRecord = {};
+
+if (
+    hasAnyDep(["prettier"], {
+        peerDeps: false,
+    })
+) {
+    hasPrettier = true;
+
+    prettierRules = {
+        "@html-eslint/no-extra-spacing-attrs": "off",
+        "@html-eslint/element-newline": "off",
+        "@html-eslint/quotes": "off",
+    }
+}
+
 const config: Linter.Config = {
-    plugins: ["html"],
+    overrides: [
+        {
+            files: ["*.erb", "*.handlebars", "*.hbs", "*.htm", "*.html", "*.mustache", "*.nunjucks", "*.php", "*.tag", "*.twig", "*.we"],
+            plugins: ["html", "@html-eslint"],
+            parser: "@html-eslint/parser",
+            extends: ["plugin:@html-eslint/recommended"],
+            globals: {
+                sourceCode: true,
+            },
+            settings: {
+                "html/indent": `+${(styleRules["indent"] as any[])[1]}`,
+                "html/report-bad-indent": hasPrettier ? "off" : "error",
+            },
+            rules: {
+                // @see https://github.com/yeonjuan/html-eslint/issues/67 bug in html-eslint
+                "spaced-comment": "off",
+                "capitalized-comments": "off",
+                "@html-eslint/indent": hasPrettier ? "off" : ["error", (styleRules["indent"] as any[])[1]],
+
+                ...prettierRules,
+            }
+        },
+    ],
 };
 
 export default config;

packages/eslint-config/src/config/plugins/jsonc.ts

@@ -1,22 +1,13 @@
 import { hasAnyDep } from "@anolilab/package-json-utils";
 import type { Linter } from "eslint";
 
-import { consoleLog } from "../../utils/loggers";
-
 const extendedPlugins: string[] = [];
 
 if (
     hasAnyDep(["prettier"], {
         peerDeps: false,
     })
 ) {
-    // Workaround VS Code trying to run this file twice!
-    if (!global.hasAnolilabEsLintConfigJsonCPrettier) {
-        global.hasAnolilabEsLintConfigJsonCPrettier = true;
-
-        consoleLog("\nFound prettier as dependency, disabling the jsonc prettier rules.");
-    }
-
     extendedPlugins.push("plugin:jsonc/prettier");
 }
 

packages/eslint-config/src/config/plugins/react.ts

@@ -16,13 +16,6 @@ if (
         peerDeps: false,
     })
 ) {
-    // Workaround VS Code trying to run this file twice!
-    if (!global.hasAnolilabEsLintConfigReactPrettier) {
-        global.hasAnolilabEsLintConfigReactPrettier = true;
-
-        consoleLog("\nFound prettier as dependency, disabling some rules to fix wrong behavior of the rule with eslint and prettier");
-    }
-
     prettierReactRules = {
         "react/jsx-child-element-spacing": "off",
         "react/jsx-closing-bracket-location": "off",

packages/eslint-config/src/config/plugins/typescript.ts

@@ -2,7 +2,6 @@ import { hasAnyDep, pkg } from "@anolilab/package-json-utils";
 import type { Linter } from "eslint";
 import { env } from "node:process";
 
-import { consoleLog } from "../../utils/loggers";
 import bestPracticesConfig from "../best-practices";
 import errorsConfig from "../errors";
 // eslint-disable-next-line unicorn/prevent-abbreviations
@@ -19,8 +18,7 @@ const eS6Rules = eS6Config.rules as Linter.RulesRecord;
 const importsRules = importsConfig.rules as Linter.RulesRecord;
 const variablesRules = variablesConfig.rules as Linter.RulesRecord;
 
-const { quotes, semi } = styleRules;
-const { indent } = styleRules;
+const { quotes, semi, indent } = styleRules;
 
 let prettierRules: Linter.RulesRecord = {};
 
@@ -29,13 +27,6 @@ if (
         peerDeps: false,
     })
 ) {
-    // Workaround VS Code trying to run this file twice!
-    if (!global.hasAnolilabEsLintConfigTypescriptPrettier) {
-        global.hasAnolilabEsLintConfigTypescriptPrettier = true;
-
-        consoleLog("\nFound prettier as dependency, disabling some rules to fix wrong behavior of the rule with eslint and prettier");
-    }
-
     prettierRules = {
         "@typescript-eslint/lines-around-comment": 0,
         "@typescript-eslint/quotes": 0,

packages/eslint-config/src/config/plugins/unicorn.ts

@@ -2,7 +2,6 @@ import { hasAnyDep, packageIsTypeModule } from "@anolilab/package-json-utils";
 import type { Linter } from "eslint";
 import semver from "semver";
 
-import { consoleLog } from "../../utils/loggers";
 import styleConfig from "../style";
 
 const styleRules = styleConfig.rules as Linter.RulesRecord;
@@ -14,13 +13,6 @@ if (
         peerDeps: false,
     })
 ) {
-    // Workaround VS Code trying to run this file twice!
-    if (!global.hasAnolilabEsLintConfigUnicornPrettier) {
-        global.hasAnolilabEsLintConfigUnicornPrettier = true;
-
-        consoleLog("\nFound prettier as dependency, disabling some rules to fix wrong behavior of the rule with eslint and prettier");
-    }
-
     prettierRules = {
         "unicorn/empty-brace-spaces": "off",
         "unicorn/no-nested-ternary": "off",

packages/eslint-config/src/global.d.ts

@@ -2,18 +2,10 @@ export {};
 
 declare global {
     var hasAnolilabEsLintConfigLoaded: boolean;
-    var hasAnolilabEsLintConfigJsonCPrettier: boolean;
-    var hasAnolilabEsLintConfigTypescriptPrettier: boolean;
 
     var hasAnolilabEsLintConfigReactRuntimePath: boolean;
 
     var hasAnolilabEsLintTestConfigLoaded: boolean;
 
-    var hasAnolilabEsLintConfigUnicornPrettier: boolean;
-
-    var hasAnolilabEsLintConfigReactPrettier: boolean;
-
-    var hasAnolilabEsLintConfigBabelPrettier: boolean;
-
     var hasAnolilabEsLintConfigPrettier: boolean;
 }