feat: removed eslint-plugin-optimize-regex, using the unicorn rule for it

Signed-off-by: prisis <d.bannert@anolilab.de>

Author: prisis

packages/commitlint-config/src/index.ts

@@ -1,4 +1,5 @@
-const automaticCommitPattern = /^chore\(release\):.*\[skip ci]/;
+// eslint-disable-next-line unicorn/better-regex
+const automaticCommitPattern = /^chore\(release\):.*\[skip ci\]/;
 
 const config = {
     extends: ["@commitlint/config-conventional"],

packages/eslint-config/README.md

@@ -374,7 +374,6 @@ The following esLint plugins enforce good coding practices:
 
 -   [eslint-plugin-array-func](https://github.com/freaktechnik/eslint-plugin-array-func)
 -   [eslint-plugin-eslint-comments](https://github.com/mysticatea/eslint-plugin-eslint-comments)
--   [eslint-plugin-optimize-regex](https://github.com/BrainMaestro/eslint-plugin-optimize-regex)
 -   [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise)
 -   [eslint-plugin-no-loops](https://github.com/buildo/eslint-plugin-no-loops)
 -   [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort)

packages/eslint-config/package.json

@@ -87,7 +87,6 @@
         "eslint-plugin-no-loops": "^0.3.0",
         "eslint-plugin-no-secrets": "^0.8.9",
         "eslint-plugin-no-use-extend-native": "^0.5.0",
-        "eslint-plugin-optimize-regex": "^1.2.1",
         "eslint-plugin-promise": "^6.1.1",
         "eslint-plugin-regexp": "^1.15.0",
         "eslint-plugin-simple-import-sort": "^10.0.0",
@@ -202,10 +201,10 @@
         "src/config/plugins/no-secrets.ts",
         "src/config/plugins/no-unsanitized.ts",
         "src/config/plugins/node.ts",
-        "src/config/plugins/optimize-regex.ts",
         "src/config/plugins/promise.ts",
         "src/config/plugins/react-hooks.ts",
         "src/config/plugins/react-redux.ts",
+        "src/config/plugins/regexp.ts",
         "src/config/plugins/react.ts",
         "src/config/plugins/security.ts",
         "src/config/plugins/simple-import-sort.ts",

packages/eslint-config/src/config.ts

@@ -8,7 +8,6 @@ const internalPluginConfig = [
     "compat",
     "eslint-comments",
     "import",
-    "optimize-regex",
     "promise",
     "simple-import-sort",
     "no-extend-native",

packages/eslint-config/src/config/best-practices.ts

@@ -244,7 +244,6 @@ const config: Linter.Config = {
             {
                 object: "global",
                 property: "isFinite",
-                // eslint-disable-next-line sonarjs/no-duplicate-string
                 message: "Please use Number.isFinite instead",
             },
             {
@@ -260,7 +259,7 @@ const config: Linter.Config = {
             {
                 object: "global",
                 property: "isNaN",
-                // eslint-disable-next-line sonarjs/no-duplicate-string
+
                 message: "Please use Number.isNaN instead",
             },
             {

packages/eslint-config/src/config/plugins/optimize-regex.ts

@@ -688,7 +688,6 @@ const config: Linter.Config = {
                 "react/jsx-wrap-multilines": [
                     "error",
                     {
-                        // eslint-disable-next-line sonarjs/no-duplicate-string
                         declaration: "parens-new-line",
                         assignment: "parens-new-line",
                         return: "parens-new-line",

packages/eslint-config/src/config/plugins/react.ts

@@ -64,7 +64,6 @@ const config: Linter.Config = {
         "comma-dangle": [
             "error",
             {
-                // eslint-disable-next-line sonarjs/no-duplicate-string
                 arrays: "always-multiline",
                 objects: "always-multiline",
                 imports: "always-multiline",

packages/eslint-config/src/config/style.ts

@@ -31,7 +31,6 @@ if (!global.hasAnolilabEsLintConfigLoaded) {
             "compat",
             "eslint-comments",
             "i",
-            "optimize-regex",
             "promise",
             "simple-import-sort",
             "unicorn",

packages/eslint-config/src/index.ts

@@ -14,6 +14,9 @@ const getType = (type: FileType) => {
         case "js_and_ts": {
             return ["*.js", "*.mjs", "*.cjs", "*.ts", "*.mts", "*.cts"];
         }
+        case "javascript": {
+            return ["*.js", "*.mjs", "*.cjs"];
+        }
         case "all": {
             return ["*.js", "*.jsx", "*.mjs", "*.cjs", "*.ts", "*.tsx", "*.mts", "*.cts"];
         }

packages/eslint-config/src/utils/create-config.ts

@@ -89,7 +89,6 @@ describe("package-json-utils", () => {
     });
 
     it("hasDep: returns true when the packageJson has the 'dependencies' property", () => {
-        // eslint-disable-next-line sonarjs/no-duplicate-string
         expect(hasDep(["read-pkg-up"])).toBeTruthy();
     });