Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add saucelabs eu dc #5083

Merged
merged 7 commits into from
Dec 19, 2018
Merged

Conversation

wswebcreation
Copy link
Contributor

Proposed changes

SauceLabs is expanding their services to other regions in the world. Protractor wants to allow user to easily pick between DCs.

Types of changes

This change allows user to define the backend region from sauce via the sauceRegion property, e.g.

    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,
    sauceRegion: 'eu',

Will run the test against https://ondemand.eu-central-1.saucelabs.com:443/wd/hub/.

    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,
    sauceRegion: 'us',

    // the default
    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,

Will run the test against https://ondemand.saucelabs.com:443/wd/hub/

It will also set the correct url for updating the status of the test

Copy link

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cnishina cnishina merged commit db1b638 into angular:master Dec 19, 2018
@wswebcreation wswebcreation deleted the fix/add-saucelabs-eu-dc branch January 4, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants