This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(browser): auto-unwrap ElementFinder into WebElement for selenium… #3471
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Julie I'm assigning this to you because it seems like a pretty consequential change |
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Nov 14, 2018
… and angularAppRoot - Enabled the driverProviderLocal tests - Remove auto unwrap test for a WebElement. Reference PR angular#3471
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Nov 14, 2018
… and angularAppRoot - Enabled the driverProviderLocal tests - Remove auto unwrap test for a WebElement. Reference PR angular#3471
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Nov 14, 2018
… and angularAppRoot - Enabled the driverProviderLocal tests - Remove auto unwrap test for a WebElement. Reference PR angular#3471
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Nov 14, 2018
… and angularAppRoot - Enabled the driverProviderLocal tests - Remove auto unwrap test for a WebElement. Reference PR angular#3471
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Nov 14, 2018
… and angularAppRoot - Enabled the driverProviderLocal tests - Remove auto unwrap test for a WebElement. Reference PR angular#3471
cnishina
added a commit
that referenced
this pull request
Nov 15, 2018
…5034) Driver providers and tests: - Use native promises over q promises in driver providers - Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests. - Enabled the driverProviderLocal tests - Clean up JSDocs for q.promise Basic lib spec: - Remove auto unwrap test for a WebElement. Reference PR #3471 Browser: - Remove control flow from waitForAngularEnabled, waitForAngular, and angularAppRoot in the Browser class.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
…ngular#5034) Driver providers and tests: - Use native promises over q promises in driver providers - Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests. - Enabled the driverProviderLocal tests - Clean up JSDocs for q.promise Basic lib spec: - Remove auto unwrap test for a WebElement. Reference PR angular#3471 Browser: - Remove control flow from waitForAngularEnabled, waitForAngular, and angularAppRoot in the Browser class.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
…ngular#5034) Driver providers and tests: - Use native promises over q promises in driver providers - Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests. - Enabled the driverProviderLocal tests - Clean up JSDocs for q.promise Basic lib spec: - Remove auto unwrap test for a WebElement. Reference PR angular#3471 Browser: - Remove control flow from waitForAngularEnabled, waitForAngular, and angularAppRoot in the Browser class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… funtions
Currently, if you do something like:
you will get a
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memoryerror because selenium doesn't know what to do with ourElementFinderclass. This solves that problem, and reduces the need for our users to know aboutgetWebElement