-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radio button provider to documentation #834
Comments
I would like to fix this to get familiar with the contribution process but have not found the similar examples in the docs or guide on where to put such dependency information.
|
@pgurenko Thanks for taking this on! I think the best place would actually be on top, before the examples (to make sure it's seen). Add a section for "Setup" and show how you'd import the symbols, add the provider to providers, and add the directives to directives. |
Something like that? SetupImporting the symbols: import { MdUniqueSelectionDispatcher } from '@angular2-material/core';
import { MD_RADIO_DIRECTIVES } from '@angular2-material/radio'; Adding providers and directives: @Component({
directives: [MD_RADIO_DIRECTIVES],
providers: [MdUniqueSelectionDispatcher]
}) |
Yeah, that looks great. Only nitpick would be to add ellipses so it's clear the selector, template, etc are missing. @Component({
...
directives: [MD_RADIO_DIRECTIVES],
providers: [MdUniqueSelectionDispatcher]
}) |
fix for "Add radio button provider to documentation angular#834". Current docs did not have the mention that radio component requires MdUniqueSelectionDispatcher provider
How is this working with the new module system? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
https://github.com/angular/material2/tree/master/src/components/radio
README doesn't mention that you need MdUniqueSelection Dispatcher.
The text was updated successfully, but these errors were encountered: