Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get HammerJS on the Google CDN #329

Closed
jelbourn opened this issue Apr 19, 2016 · 4 comments
Closed

Get HammerJS on the Google CDN #329

jelbourn opened this issue Apr 19, 2016 · 4 comments
Assignees
@naomiblack
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Milestone
alpha.4

Comments

@jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Apr 19, 2016
@jelbourn jelbourn added this to the alpha.4 milestone Apr 19, 2016
@naomiblack
Copy link
Contributor

Do we want hammer.js or hammer-time.js? See http://hammerjs.github.io/

@kara
Copy link
Contributor

kara commented Apr 27, 2016 •
edited
Loading

Hammer.js :D

@naomiblack
Copy link
Contributor

https://developers.google.com/speed/libraries/#hammerjs

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@devversion @jelbourn
fix: create proper fragment urls (angular#329)
89a6cf1 
By default fragment links are referring to the root page and the actual hash won't matter anymore. This can be fixed in a similar way to the `header-link` directive by updating the anchor URLs to include the current base URL.

Since those are normal links and aren't `header-links`, the `header-link` directive is not an option. A directive that updates the links accordingly would be perfect, but there is no way to interpolate directives on those HTML templates dynamically.

Having a component that creates/wraps the anchor elements is wrong and adds more pain than it helps. The links should can be just updated using simple DOM manipulation.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@naomiblack naomiblack

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
alpha.4
Development

No branches or pull requests
3 participants
@jelbourn @naomiblack @kara