Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour of Heroes app uses angular2-material #199

Closed
jelbourn opened this issue Mar 17, 2016 · 10 comments
Closed

Tour of Heroes app uses angular2-material #199

jelbourn opened this issue Mar 17, 2016 · 10 comments
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue
Milestone

Comments

@jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Mar 17, 2016
@jelbourn jelbourn self-assigned this Mar 17, 2016
@jelbourn jelbourn added this to the alpha.2 milestone Mar 17, 2016
@m0t0r
Copy link

m0t0r commented Mar 18, 2016

@jelbourn, is this issue good for community contribution ?

@jelbourn jelbourn added the help wanted The team would appreciate a PR from the community to address this issue label Mar 18, 2016
@jelbourn
Copy link
Member Author

@m0t0r sure, but it's @johnpapa that owns that app; I mainly made this issue to remind myself to talk to him about it.

@m0t0r
Copy link

m0t0r commented Mar 18, 2016

Okay, I think I can find time in a couple of days and I would like to help. @jelbourn what do think is the best way to start ? Should I wait for @johnpapa's instructions ? what exactly is expected ? something like a written guidelines of original Tour of Heroes but replaced with material2 components + app?

@johnpapa
Copy link

yes, i want ToH to use AM2 once its ready

@jelbourn
Copy link
Member Author

@johnpapa if you let us know which components the app uses / needs, I can let you know when we're ~ready to try it out.

@jelbourn jelbourn modified the milestones: alpha.2, alpha.4 Apr 4, 2016
@mswift42 mswift42 mentioned this issue Apr 6, 2016
8 tasks
@jelbourn jelbourn modified the milestones: before beta, alpha.4 Apr 12, 2016
@BernhardRode
Copy link

I think AM2 is a bit to much for the basic ToH, beginners will be overwhelmed.

@ciasej
Copy link

ciasej commented Jun 12, 2016

Instead of rewriting the original TOH would it be better to provide an additional section to the end of the existing guide that shows developers how to update the completed TOH app and it's components into md2 components?

@jelbourn
Copy link
Member Author

Planning now to have a separate starter app / tutorial for Material.

@imVinayPandya
Copy link

@jelbourn have to created AM2 starter app / tutorial for material? I hope it will have universal + AM2 + Angular 5+ supports.

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
* Fixes that the Plunker form does not contain the source-files from the associated example.

Fixes angular#5245
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Development

No branches or pull requests

6 participants