Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should fail when encountering ddescribe, iit, debugger, etc. #175

Closed
jelbourn opened this issue Mar 16, 2016 · 1 comment
Closed

CI should fail when encountering ddescribe, iit, debugger, etc. #175

jelbourn opened this issue Mar 16, 2016 · 1 comment
Labels
area: dev-infra Issue related to internal project infrastructure help wanted The team would appreciate a PR from the community to address this issue

Comments

@jelbourn
Copy link
Member

Travis CI should fail whenever one of the following is accidentally left in a commit.

  • ddescribe
  • fdescribe
  • iit
  • fit
  • xdescribe
  • xit
  • debugger;

We want this to not apply to import statements for the jasmine statements.
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue area: dev-infra Issue related to internal project infrastructure labels Mar 16, 2016
@jelbourn jelbourn changed the title CI should fail when encountering ddescript, iit, debugger, etc. CI should fail when encountering ddescribe, iit, debugger, etc. Mar 16, 2016
devversion added a commit to devversion/material2 that referenced this issue Mar 16, 2016
@devversion
chore: analyze travis commit and check for blocked statements.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
GPG key ID: FE918C3A98C1030F
Expired
Verified
Learn about vigilant mode
64930ee 
Fixes angular#175.
@devversion devversion mentioned this issue Mar 16, 2016
Closed
devversion added a commit to devversion/material2 that referenced this issue Mar 17, 2016
@devversion
chore: analyze travis commit and check for blocked statements.
0662d79 
Fixes angular#175.
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@amcdnl @jelbourn
feat(PWA): add service worker angular#175 (angular#223)
b684808
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: dev-infra Issue related to internal project infrastructure help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: analyze travis commit and check for blocked statements. devversion/material2
1 participant
@jelbourn