fix(material/autocomplete): incorrectly resolving focused element in shadow DOM #30619
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shadow DOM There are a few places where the autocomplete was checking if it has focus which were breaking down when inside the shadow DOM, because `document.activeElement` will point to the closest shadow root. These changes consolidate the places where we check for focus and use our utility for resolving the focused element through shadow boundaries. Fixes angular#30611.
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
wagnermaciel
approved these changes
Mar 12, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Mar 12, 2025
…shadow DOM (#30619) There are a few places where the autocomplete was checking if it has focus which were breaking down when inside the shadow DOM, because `document.activeElement` will point to the closest shadow root. These changes consolidate the places where we check for focus and use our utility for resolving the focused element through shadow boundaries. Fixes #30611. (cherry picked from commit e61d152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where the autocomplete was checking if it has focus which were breaking down when inside the shadow DOM, because
document.activeElementwill point to the closest shadow root.These changes consolidate the places where we check for focus and use our utility for resolving the focused element through shadow boundaries.
Fixes #30611.