fix(multiple): deprecate exported factories #30608
Merged
+258
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of factory functions that made it into our public API as a result of an old ViewEngine limitation where the factories had to be separate variables and had to be exported. With Ivy this isn't necessary and the factories can be inlined. Also they were never meant to be public APIs. These changes mark them as deprecated so they can be dropped from the public API in v21.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Mar 10, 2025
| /** | ||
| * @docs-private | ||
| * @deprecated No longer used, will be removed. | ||
| * @breaking-change 21.0.0 |
There was a problem hiding this comment.
Shouldn't this be v22, since it'd be deprecated during two major releases (v20, v21)? Or does v19 count as one (feels a little late for that)
There was a problem hiding this comment.
The way I interpreted it is that it would have to be deprecated during two major versions: 19 and 20.
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Mar 12, 2025
There are a bunch of factory functions that made it into our public API as a result of an old ViewEngine limitation where the factories had to be separate variables and had to be exported. With Ivy this isn't necessary and the factories can be inlined. Also they were never meant to be public APIs. These changes mark them as deprecated so they can be dropped from the public API in v21. (cherry picked from commit 810495c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of factory functions that made it into our public API as a result of an old ViewEngine limitation where the factories had to be separate variables and had to be exported. With Ivy this isn't necessary and the factories can be inlined. Also they were never meant to be public APIs.
These changes mark them as deprecated so they can be dropped from the public API in v21.