Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/schematics): some options missing from schema #30602

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 7, 2025

Fixes that the neutralVariantColor and errorColor were missing from the schema which meant that users can't pass them in.

Fixes #30571.

Fixes that the `neutralVariantColor` and `errorColor` were missing from the schema which meant that users can't pass them in.

Fixes angular#30571.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 7, 2025
@crisbeto crisbeto requested a review from a team as a code owner March 7, 2025 12:56
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team March 7, 2025 12:56
@crisbeto crisbeto removed the request for review from wagnermaciel March 7, 2025 18:14
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2025
@crisbeto crisbeto merged commit da371e9 into angular:main Mar 7, 2025
21 of 23 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Mar 7, 2025

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Mar 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes that the `neutralVariantColor` and `errorColor` were missing from the schema which meant that users can't pass them in.

Fixes #30571.

(cherry picked from commit da371e9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(theme-generator): errorColor and neutralVariantColor missing in schema
2 participants