Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/timepicker): wrong default scroll strategy #30593

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2025

#30561 accidentally switched the default scroll strategy for the timepicker to be close instead of reposition. It was unintentional so these changes switch it back to reposition.

angular#30561 accidentally switched the default scroll strategy for the timepicker to be `close` instead of `reposition`. It was unintentional so these changes switch it back to `reposition`.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 6, 2025
@crisbeto crisbeto requested a review from a team as a code owner March 6, 2025 08:19
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team March 6, 2025 08:19
@crisbeto crisbeto removed the request for review from mmalerba March 6, 2025 17:23
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2025
@crisbeto crisbeto merged commit 3a97011 into angular:main Mar 6, 2025
23 of 25 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Mar 6, 2025

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Mar 6, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#30561 accidentally switched the default scroll strategy for the timepicker to be `close` instead of `reposition`. It was unintentional so these changes switch it back to `reposition`.

(cherry picked from commit 3a97011)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/timepicker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants