Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/list): option views not change detected when control is disabled #30532

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

crisbeto
Copy link
Member

Fixes that we weren't change detecting the view of the selection list options when the form control for the entire list is disabled. The visual difference is subtle for unchecked options, but it's noticeable for checked ones.

Fixes #30522.

…disabled

Fixes that we weren't change detecting the view of the selection list options when the form control for the entire list is disabled. The visual difference is subtle for unchecked options, but it's noticeable for checked ones.

Fixes angular#30522.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 21, 2025
@crisbeto crisbeto requested a review from a team as a code owner February 21, 2025 08:16
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team February 21, 2025 08:16
@crisbeto crisbeto removed the request for review from mmalerba February 21, 2025 20:54
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 21, 2025
@crisbeto crisbeto merged commit 8b2b944 into angular:main Feb 21, 2025
23 of 25 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.1.x, 19.2.x

crisbeto added a commit that referenced this pull request Feb 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…disabled (#30532)

Fixes that we weren't change detecting the view of the selection list options when the form control for the entire list is disabled. The visual difference is subtle for unchecked options, but it's noticeable for checked ones.

Fixes #30522.

(cherry picked from commit 8b2b944)
crisbeto added a commit that referenced this pull request Feb 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…disabled (#30532)

Fixes that we weren't change detecting the view of the selection list options when the form control for the entire list is disabled. The visual difference is subtle for unchecked options, but it's noticeable for checked ones.

Fixes #30522.

(cherry picked from commit 8b2b944)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/list target: patch This PR is targeted for the next patch release
Projects
None yet
2 participants