Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/form-field): trigger CD when form gets reassigned #30395

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix(material/form-field): trigger CD when form gets reassigned #30395

merged 1 commit into from
Feb 20, 2025
+90 −1

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jan 27, 2025

fixes the issue we were not marking component for changes when form is reassigned making it not update UI for required asterisk

fixes #29066

@naaajii naaajii requested a review from a team as a code owner January 27, 2025 12:48
@naaajii naaajii requested review from crisbeto and wagnermaciel and removed request for a team January 27, 2025 12:48
mmalerba
mmalerba requested changes Feb 4, 2025
View reviewed changes
mmalerba
mmalerba reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, I was too trigger happy with the approve before I noticed the test was still failing

@motka
Copy link

motka commented Feb 5, 2025

no more working

@naaajii naaajii requested a review from mmalerba February 5, 2025 17:57
@naaajii
fix(material/form-field): trigger CD when form
Loading
Loading status checks…
2994a25 
gets reassigned

fixes the issue we were not marking component
for changes when form is reassigned making it
not update UI for required asterisk

fixes angular#29066
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 20, 2025
@mmalerba mmalerba merged commit cdb1592 into angular:main Feb 20, 2025
24 checks passed
@mmalerba
Copy link
Contributor

The changes were merged into the following branches: main, 19.1.x, 19.2.x

mmalerba pushed a commit that referenced this pull request Feb 20, 2025
@naaajii @mmalerba
fix(material/form-field): trigger CD when form (#30395)
Loading
Loading status checks…
ec8c300 
gets reassigned

fixes the issue we were not marking component
for changes when form is reassigned making it
not update UI for required asterisk

fixes #29066

(cherry picked from commit cdb1592)
mmalerba pushed a commit that referenced this pull request Feb 20, 2025
@naaajii @mmalerba
fix(material/form-field): trigger CD when form (#30395)
Loading
Loading status checks…
e70145b 
gets reassigned

fixes the issue we were not marking component
for changes when form is reassigned making it
not update UI for required asterisk

fixes #29066

(cherry picked from commit cdb1592)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/form-field target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(matInput): Form field doesn't update asterisk after the form was reassigned
3 participants
@naaajii @motka @mmalerba