-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/text-field): Long multiline textfield focus issue #30312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/text-field): Long multiline textfield focus issue #30312
Conversation
a6c08d5
to
c7256b2
Compare
60af3c5
to
aff4247
Compare
dc6c818
to
4e82db5
Compare
4e82db5
to
7a6fb23
Compare
7a6fb23
to
ef1303f
Compare
ef1303f
to
03ed47b
Compare
When we have long multiline textfield and put cursor on almost an end (For eg. on 3rd last line) the scroll moves up to the top of textarea. This fix will cache the `scrollTop` in `resizeToFitContent` method Fixes angular#20255
03ed47b
to
a9be63e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@mmalerba let me know if you want me to rebase the branch with the latest changes in main. |
It looks like there's no conflicts so its fine for now, we just need to run it against google's internal tests and see if anything fails |
Today I updated the CDK version from v18.x to v19.2.8 during the Angular v18 to v19 migration of our mono repo and noticed a regression in our textarea component that uses the CdkTextareaAutosize. The regression happens when enough rows have been inserted at the bottom of the text area to reach the maxRows limit and cause the textarea to overflow. |
When we have a long multiline textfield and put the cursor on almost an end (For example, on 3rd last line), the scroll moves up to the top of textarea. This fix will cache the
scrollTop
in theresizeToFitContent
methodFixes #20255