refactor(material/core): split token utils #29498
Merged
+927
−884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
force-pushed
the
split-util-deps
branch
4 times, most recently
from
6baf06c to
ab3ff63
Compare
andrewseguin
requested review from
crisbeto and
amysorto
and removed request for
a team
crisbeto
approved these changes
Jul 28, 2024
andrewseguin
added
action: merge
andrewseguin
force-pushed
the
split-util-deps
branch
from
6f70486 to
327d49d
Compare
crisbeto
approved these changes
Jul 29, 2024
crisbeto
pushed a commit
that referenced
this pull request
Jul 29, 2024
* refactor(material/core): use util to build token vars * rename to just token-definition (cherry picked from commit 0a6b3ea)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-op change that moves a subset of
token-utils.scssfunctions into their own util file calledtoken-definition-utils.scss. This is necessary to avoid circular deps in any future changes where_token-utils.scssneeds to depend onm3-tokens.scss(for system fallbacks)