-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/core): add migration for M2 theming APIs #28927
Conversation
Adds a migration to account for the breaking changes in angular#28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.
} | ||
} | ||
|
||
// If experimental is imported, but Material isn't, insert a new import at the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the theming just not work in this case if people are doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some cases like with the color-back-compat
mixin that could be used purely through experimental.
} | ||
|
||
/** Renames all usages of a Sass function in a file. */ | ||
function migrateFunction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of these helper functions might be useful to be in some shared place for any future ng-update schematics. Although I guess it's unlikely we would need these in another context soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I actually copied most of these from a migration that we deleted a few versions ago.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a migration to account for the breaking changes in #28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.