fix(material-experimental/theming): Add more tests for M3 theme tokens #28561
+138
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
crisbeto,
andrewseguin and
jelbourn
as code owners
crisbeto
approved these changes
Feb 8, 2024
Additional tests that help ensure our M3 theme conforms to the following rules: - Does not add any additional selector specificity - Emits only CSS variable definitions - Emits each token for one and only one theme dimension Also fixes several existing bugs that were discovered by the new tests.
mmalerba
added
target: rc
mmalerba
added a commit
that referenced
this pull request
Feb 9, 2024
#28561) Additional tests that help ensure our M3 theme conforms to the following rules: - Does not add any additional selector specificity - Emits only CSS variable definitions - Emits each token for one and only one theme dimension Also fixes several existing bugs that were discovered by the new tests. (cherry picked from commit acf72e1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tests that help ensure our M3 theme conforms to the following rules:
Also fixes several existing bugs that were discovered by the new tests.