Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/theming): disabled radio button incorrect label color #28415

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(material-experimental/theming): disabled radio button incorrect label color #28415

merged 1 commit into from
Jan 12, 2024
+8 −9

Conversation

crisbeto
Copy link
Member

Fixes that disabled radio buttons didn't have the correct color of the label when disabled. Also switches some existing rgba calls to use the safe-color-change function.

@crisbeto
fix(material-experimental/theming): disabled radio button incorrect l…
40d5651 
…abel color

Fixes that disabled radio buttons didn't have the correct color of the label when disabled. Also switches some existing `rgba` calls to use the `safe-color-change` function.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Jan 12, 2024
@crisbeto crisbeto requested a review from andrewseguin January 12, 2024 10:15
@crisbeto crisbeto requested a review from mmalerba as a code owner January 12, 2024 10:15
mmalerba
mmalerba approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto self-assigned this Jan 12, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 12, 2024
@crisbeto crisbeto removed the request for review from andrewseguin January 12, 2024 22:06
@crisbeto crisbeto merged commit 339905c into angular:main Jan 12, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crisbeto @mmalerba