fix(material-experimental/theming): Update M3 palettes #28109
Merged
+390
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last time I checked, the M3 theme generator generated the same neutral palette regardless of the primary color used. That didn't really make much sense, because it caused the neutral colors to always have a purplish tint. It seems like maybe a bug that was fixed, because now it generates different neutral colors depending on the primary. I've updated our pre-defined palettes to capture these different neutrals. I created a script to convert the MDC theme builder exports to our palette CSS format. I'm not including it as part of this commit, but just FYI that it'll be cheap to add to / update our predefined palettes in the future. If we want the script checked in I can clean it up and make a separate PR for it.
mmalerba
force-pushed
the
m3-palettes
branch
from
64b6399 to
e4055f0
Compare
crisbeto
approved these changes
Nov 15, 2023
mmalerba
added a commit
that referenced
this pull request
Nov 15, 2023
Last time I checked, the M3 theme generator generated the same neutral palette regardless of the primary color used. That didn't really make much sense, because it caused the neutral colors to always have a purplish tint. It seems like maybe a bug that was fixed, because now it generates different neutral colors depending on the primary. I've updated our pre-defined palettes to capture these different neutrals. I created a script to convert the MDC theme builder exports to our palette CSS format. I'm not including it as part of this commit, but just FYI that it'll be cheap to add to / update our predefined palettes in the future. If we want the script checked in I can clean it up and make a separate PR for it. (cherry picked from commit 1735032)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I checked, the M3 theme generator generated the same neutral palette regardless of the primary color used. That didn't really make much sense, because it caused the neutral colors to always have a purplish tint. It seems like maybe a bug that was fixed, because now it generates different neutral colors depending on the primary.
I've updated our pre-defined palettes to capture these different neutrals. I created a script to convert the MDC theme builder exports to our palette CSS format. I'm not including it as part of this commit, but just FYI that it'll be cheap to add to / update our predefined palettes in the future. If we want the script checked in I can clean it up and make a separate PR for it.