Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/table): the CdkNoDataRow directive does not render in the OnPush strategy #27687

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix(cdk/table): the CdkNoDataRow directive does not render in the OnPush strategy #27687

merged 1 commit into from
Aug 22, 2023
+75 −4

Conversation

kryshac
Copy link
Contributor

@kryshac kryshac commented Aug 20, 2023

fix(cdk/table): the CdkNoDataRow directive does not render in the OnPush strategy

Fixes a bug in the Angular CDK table component where the CdkNoDataRow directive with binding data is not rendered correctly when the parent component has the OnPush strategy set

@kryshac
fix(cdk/table): the CdkNoDataRow directive does not render in the OnP…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
045aeff 
…ush strategy

Fixes a bug in the Angular CDK `table` component where the CdkNoDataRow directive with binding data
is not rendered correctly when the parent component has the OnPush strategy set
@kryshac kryshac requested a review from andrewseguin as a code owner August 20, 2023 12:39
crisbeto
crisbeto approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto self-assigned this Aug 22, 2023
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 22, 2023
@crisbeto crisbeto merged commit ca9c490 into angular:main Aug 22, 2023
crisbeto pushed a commit that referenced this pull request Aug 22, 2023
@kryshac @crisbeto
fix(cdk/table): the CdkNoDataRow directive does not render in the OnP…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8511b74 
…ush strategy (#27687)

Fixes a bug in the Angular CDK `table` component where the CdkNoDataRow directive with binding data
is not rendered correctly when the parent component has the OnPush strategy set

(cherry picked from commit ca9c490)
@PadureanuAndrei
Copy link

best solution. thanks @kryshac for attitude and passion

@kryshac kryshac deleted the cdk-table branch August 22, 2023 15:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

@andrewseguin andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kryshac @PadureanuAndrei @crisbeto