Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved missing dateAdapters error message to include matLuxon and matDateFns #26889

Conversation

JelleBruisten
Copy link
Contributor

@JelleBruisten JelleBruisten commented Apr 6, 2023

The error message for missing dateAdapter was missing MatDateFnsModule and MatLuxonDateModule this pr updates the error message to include these modules

@google-cla
Copy link

google-cla bot commented Apr 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JelleBruisten
Copy link
Contributor Author

JelleBruisten commented Apr 6, 2023

Can someone help me resolve the CLA status? It does say I already signed:

It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below.

edit: Solved it

@JelleBruisten JelleBruisten force-pushed the fix/improved-error-message-when-missing-provider branch from 6cec9b0 to f8186b2 Compare April 6, 2023 18:02
@JelleBruisten JelleBruisten force-pushed the fix/improved-error-message-when-missing-provider branch from f8186b2 to f16a5e2 Compare April 6, 2023 19:05
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba self-assigned this Jun 22, 2023
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 22, 2023
@mmalerba mmalerba merged commit 4c3ef50 into angular:main Sep 26, 2023
mmalerba pushed a commit that referenced this pull request Sep 26, 2023
… to include matLuxon and matDateFns (#26889)

(cherry picked from commit 4c3ef50)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants