Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 15 commits
- 131 files changed
- 6 contributors
Commits on Mar 19, 2025
-
build: support linking of Angular libraries with
rules_jsFor linking of Angular packages we are using something more clever than what we are doing with `rules_nodejs`. Instead of maintaing complexity where we pre-link FESM bundles and somehow inject them into other Bazel bundling steps (with complex linker mappings), we pre-link as part of individual package postinstall steps, exposing the linked bundles via a NodeJS exports condition. This is possible vis this package/script: https://github.com/devversion/angular-linking Clearly this is not at a good location, but it's necessary right now to ship this code via npm because `rules_js` struggles to use pnpm extensions onto workspace 1st-party packages. Long-term we can either decide to keep it that way, move it into e.g. dev-infra repository, or we can explore shipping pre-linked bundles via APF. TBD.
-
build: migrate all
ts_librarytargets intools/Migrates all `ts_library` targets in `tools/` to use the `rules_js` `ts_project` rule.
-
build: improve
ts_projectinterop to work with esbuild bundlingImproves the `ts_project` interop to work with Esbuild bundling. Right now we can end up with multiple copies of the same source file. e.g. input might import from `@angular/cdk/testing` and end up with the version of `rules_nodejs` linker, while other imports to the native `ts_library` targets end up being mapped to their actual sources in the `bazel-bin`, and not inside `node_modules`
-
build: migrate more
ts_librarytargets torules_jsMigrates more `ts_library` targets to `rules_js`
-
refactor(multiple): consolidate logic for disabling animations
Adds a common function we can use to determine whether animations are disabled globally. This reduces duplication and makes it easier to change the logic.
-
refactor(cdk/overlay): add config option for disabling animations
Currently the CDK overlay uses `ANIMATION_MODULE_TYPE` to implicitly disable the backdrop animation, however we want to introduce a Material-specific way of disabling animations. These changes add a config option that we can use to do so.
-
fix(material/timepicker): TimepickerInput component in shadow DOM (#3…
…0642) Fixes an issue where the value of the input element referenced by a TimepickerInput component inside a shadow DOM was getting formatted too often due to `TimepickerInput._hasFocus()` assuming the component wasn't in the shadow DOM. Fixes #30641 Co-authored-by: Caleb Kish <j69674031@gmail.com>
-
fix(cdk/tree): retainining previous objects (#30431)
fixes component retaining old data in memory even when its not used causing memory usage to increase fixes #30322
Commits on Mar 20, 2025
-
fix(material/chips): chip input not showing placeholder (#30664)
The chip input is inheriting some styles from `MatInput` which were causing it not to show its placeholder unless it's focused. These changes override the inherited styles to show it correctly. Fixes #16380.
-
fix(material/chips): implement disabledInteractive in chip input (#30665
-
fix(multiple): ensure re-exported module symbols can be imported (#30667
) As of recently, we switched our imports from module imports to relative imports, when inside the same package. This is expected for proper code splitting, and also for our upcoming `rules_js` migration. Unfortunately this highlights an issue with the Angular compiler. We occasionally re-export other entry-point modules from one entry-point module. This is likely done for convenience, but we should stop doing that going forward (and likely will naturally resolve this over time with standalone either way). The problem is that the Angular compiler, especially with HMR enabled (i.e. no tree-shaking of imports), will try to generate imports in the user code to symbols that are indirectly re-exported. This worked before because the Angular compiler leveraged the "best guessed module", based on the "last module import" it saw before e.g. discovering the re-exported `ScrollingModule`; hence it assumed all exports of that module are available from `@angular/cdk/scrolling`. This assumption no longer works because the last module import would be e.g. `cdk/overlay`, which relatively imports from scrolling to re-export the module then. There are a few options: - teach the compiler about relative imports inside APF packages with secondary entry-points. Possible, but won't work for users with older compiler versions. Maybe a long-term good thing to do; on the other hand, standalone is the new future. - switch back to module imports. Not possible and relative imports should work inside a package IMO. - re-export the exposed symbols, under a private name. This is the easiest approach and there also aren't a lot of module re-exports; so this is a viable approach taken by this commit. Inside Google, the latter approach is automatically emitted by the compiler, when everything is built from source; but that's not usable here; but confirms this approach as being reasonable. Ideally we will stop re-exporting modules in APF packages, and long-term we start supporting the proper module guessing with relative imports. Fixes #30663.
-
Commits on Mar 21, 2025
-
fix(cdk/overlay): ensure re-exported transitive
Dirdirective can b……e imported (#30679) This is a follow-up to cb3b0a8 which did miss this transitive re-export of the `Dir` directive. The compiler will try the last module import, so even if e.g. `./scrolling` re-exported `Dir` as of the initial commit, the compiler would try importing via `@angular/cdk/overlay`. This commit fixes this remaining instance, and updates the new testing infrastructure to import/test every module in isolation. The tests didn't notice that issue because the compiler discovered the `Dir` directive/"Reference" already via another import that "worked". Fixes #30663.
-
-
There are no files selected for viewing