Skip to content

Commit cb1450f

Browse files
authoredAug 21, 2024··
fix(multiple): change fallbacks to use m3 (#29528)
1 parent 9323bf4 commit cb1450f

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed
 

‎src/material/core/_core.scss

+8
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@
77

88
// Mixin that renders all of the core styles that are not theme-dependent.
99
@mixin core() {
10+
// TODO: Move ripple styles to be dynamically loaded instead of in core.
11+
// This variable is used as a fallback for the ripple element's
12+
// background color. However, if it isn't defined anywhere, then MSS
13+
// complains in its verification stage.
14+
html {
15+
--mat-app-on-surface: initial;
16+
}
17+
1018
@include ripple.ripple();
1119
@include cdk.a11y-visually-hidden();
1220
@include cdk.overlay();

‎src/material/core/tokens/_token-utils.scss

+1-5
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,7 @@ $_system-fallbacks: m3-tokens.create-system-fallbacks();
113113
@return _create-var($sys-fallback, $fallback);
114114
}
115115

116-
// TODO(mat-app-theme): Return the system-level fallback.
117-
// Changing this will affect clients that do not properly call theme mixins since the tokens
118-
// will be undefined and now default to M3 system values, causing a number of screenshot failures.
119-
// @return $sys-fallback;
120-
@return $fallback;
116+
@return $sys-fallback;
121117
}
122118

123119
// Outputs a map of tokens under a specific prefix.

0 commit comments

Comments
 (0)
Please sign in to comment.