Skip to content

Commit b124bb4

Browse files
committedOct 10, 2024
fix: errors when reading optional queries
Some optional queries were incorrectly marked as required which was throwing runtime errors.
1 parent 5a8cb62 commit b124bb4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed
 

‎material.angular.io/src/app/pages/component-sidenav/component-sidenav.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</mat-sidenav>
1111
}
1212
<div class="docs-component-sidenav-content">
13-
<component-page-header (toggleSidenav)="toggleSidenav(sidenav())"></component-page-header>
13+
<component-page-header (toggleSidenav)="toggleSidenav()"></component-page-header>
1414
<div class="docs-component-sidenav-inner-content">
1515
<main class="docs-component-sidenav-body-content">
1616
<!-- If on large screen, menu resides to left of content -->

‎material.angular.io/src/app/pages/component-sidenav/component-sidenav.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const SMALL_WIDTH_BREAKPOINT = 959;
8282
],
8383
})
8484
export class ComponentSidenav implements OnInit, OnDestroy {
85-
readonly sidenav = viewChild.required(MatSidenav);
85+
readonly sidenav = viewChild(MatSidenav);
8686
params: Observable<Params> | undefined;
8787
isExtraScreenSmall: Observable<boolean>;
8888
isScreenSmall: Observable<boolean>;
@@ -120,8 +120,8 @@ export class ComponentSidenav implements OnInit, OnDestroy {
120120
this.subscriptions.unsubscribe();
121121
}
122122

123-
toggleSidenav(sidenav: MatSidenav): Promise<MatDrawerToggleResult> {
124-
return sidenav.toggle();
123+
toggleSidenav(): void {
124+
this.sidenav()?.toggle();
125125
}
126126
}
127127

‎material.angular.io/src/app/pages/component-viewer/component-viewer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class ComponentViewer implements OnDestroy {
9494
*/
9595
@Directive()
9696
export class ComponentBaseView implements OnInit, OnDestroy {
97-
readonly tableOfContents = viewChild.required<TableOfContents>('toc');
97+
readonly tableOfContents = viewChild<TableOfContents>('toc');
9898
readonly viewers = viewChildren(DocViewer);
9999

100100
showToc: Observable<boolean>;

0 commit comments

Comments
 (0)
Please sign in to comment.