Skip to content

Commit 93d7413

Browse files
authoredJul 21, 2020
fix: footer not being pushed to the bottom of the page in guides (#839)
Fixes a regression caused by #834 which means that the footer stays in place right after the fold on the page, instead of being pushed to the bottom. Fixes #20049.
1 parent ef14525 commit 93d7413

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed
 

‎material.angular.io/src/app/pages/guide-viewer/guide-viewer.scss

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ $guide-content-margin-side-xs: 15px;
1616
display: block;
1717
text-align: center;
1818

19-
// Ensures that the footer is pushed to the bottom and prevents
20-
// the page from jumping around while something is loading.
21-
min-height: 100vh;
22-
2319
@media ($mat-xsmall) {
2420
padding-left: $content-padding-side-xs;
2521
padding-right: $content-padding-side-xs;
@@ -34,6 +30,10 @@ $guide-content-margin-side-xs: 15px;
3430
max-width: 940px;
3531
margin: 0 auto;
3632

33+
// Ensures that the footer is pushed to the bottom and prevents
34+
// the page from jumping around while something is loading.
35+
min-height: 100vh;
36+
3737
@media (max-width: $extra-small-breakpoint-width) {
3838
flex-direction: column;
3939
}

‎material.angular.io/yarn.lock

-6
Original file line numberDiff line numberDiff line change
@@ -208,12 +208,6 @@
208208
dependencies:
209209
tslib "^2.0.0"
210210

211-
"@angular/components-examples@https://github.com/angular/material2-docs-content.git#33b7ab32041e2845fb82497ff304c86690fded90":
212-
version "10.1.0-next.0-sha-57f20bfb9"
213-
resolved "https://github.com/angular/material2-docs-content.git#33b7ab32041e2845fb82497ff304c86690fded90"
214-
dependencies:
215-
tslib "^2.0.0"
216-
217211
"@angular/core@^10.0.1":
218212
version "10.0.1"
219213
resolved "https://registry.yarnpkg.com/@angular/core/-/core-10.0.1.tgz#7737de1e7e382034e86dcff32282af8c209a7787"

0 commit comments

Comments
 (0)
Please sign in to comment.