-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zone.js): add missing APIs to Node.js fs
patch
#54396
Conversation
2354b5b
to
f49a7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
This commit updates the list of Node.js `fs` APIs to be patched because they haven't been updated for a long time. It adds `opendir,lutimes,writev`. For example, the `opendir` method was added to Node.js in version 12.12.0 in 2019, causing some of the APIs to potentially be always called within the `<root>` context. **Note:** There are missing unit tests for these changes because in unit tests, `fs` is patched by Bazel's Node.js rules and its `node_patches.cjs`. However, the APIs are successfully patched in the real production code and are called with the correct context.
f49a7ac
to
2a83d24
Compare
Caretaker note: TGP is "green", this PR is ready for merge. |
This PR was merged into the repository by commit 9e07b62. |
This commit updates the list of Node.js `fs` APIs to be patched because they haven't been updated for a long time. It adds `opendir,lutimes,writev`. For example, the `opendir` method was added to Node.js in version 12.12.0 in 2019, causing some of the APIs to potentially be always called within the `<root>` context. **Note:** There are missing unit tests for these changes because in unit tests, `fs` is patched by Bazel's Node.js rules and its `node_patches.cjs`. However, the APIs are successfully patched in the real production code and are called with the correct context. PR Close #54396
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit updates the list of Node.js
fs
APIs to be patched becausethey haven't been updated for a long time. It adds
opendir,lutimes,writev
.For example, the
opendir
method was added to Node.js in version 12.12.0 in2019, causing some of the APIs to potentially be always called within the
<root>
context.Note: There are missing unit tests for these changes because in unit tests,
fs
is patched by Bazel's Node.js rules and itsnode_patches.cjs
. However,the APIs are successfully patched in the real production code and are called
with the correct context.