-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): Ensure canceledNavigationResolution: 'computed'
works …
#51441
Conversation
…on first page Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally `undefined` page ID to be used again when the router performs its initial navigation. fixes angular#50983
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
… works on first page
f23e5ff
to
686bab2
Compare
This PR was merged into the repository by commit 96d94ad. |
…on first page (angular#51441) Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally `undefined` page ID to be used again when the router performs its initial navigation. fixes angular#50983 PR Close angular#51441
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…on first page (angular#51441) Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally `undefined` page ID to be used again when the router performs its initial navigation. fixes angular#50983 PR Close angular#51441
…on first page
Setting the page ID is currently broken for the first page because the helper method's second parameter is optional, which allowed the initally
undefined
page ID to be used again when the router performs its initial navigation.fixes #50983