-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): guard the jasmine hooks #51394
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Aug 16, 2023
JeanMeche
force-pushed
the
fix/hooks
branch
2 times, most recently
from
August 16, 2023 21:37
4cdd996
to
406f235
Compare
This commit fixes a regression introduced in angular#50063 Fixes angular#51382
JoostK
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
regression
Indicates than the issue relates to something that worked in a previous version
area: core
Issues related to the framework runtime
target: patch
This PR is targeted for the next patch release
P2
The issue is important to a large percentage of users, with a workaround
labels
Aug 17, 2023
AndrewKushnir
added
the
action: global presubmit
The PR is in need of a google3 global presubmit
label
Aug 20, 2023
AndrewKushnir
approved these changes
Aug 20, 2023
Caretaker note: global presubmit is "green", this PR is ready for merge. |
AndrewKushnir
added
action: merge
The PR is ready for merge by the caretaker
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
action: global presubmit
The PR is in need of a google3 global presubmit
labels
Aug 20, 2023
This PR was merged into the repository by commit a9b3c00. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 21, 2023
thomasturrell
pushed a commit
to thomasturrell/angular
that referenced
this pull request
Aug 29, 2023
This commit fixes a regression introduced in angular#50063 Fixes angular#51382 PR Close angular#51394
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit fixes a regression introduced in angular#50063 Fixes angular#51382 PR Close angular#51394
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: core
Issues related to the framework runtime
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
P2
The issue is important to a large percentage of users, with a workaround
regression
Indicates than the issue relates to something that worked in a previous version
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in #50063
Fixes #51382