fix(compiler): compute correct offsets when interpolations have HTML entities #44811
+131
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
encodedentitybug
branch
4 times, most recently
from
144d5a0 to
2243930
Compare
…entities
When parsing interpolations, the input string is _decoded_ from what was
in the orginal template. This means that we cannot soley rely on the input
string to compute source spans because it does not necessarily reflect
the exact content of the original template. Specifically, when there is
an HTML entity (i.e. ` `), this will show up in its decoded form
when processing the interpolation (' '). We need to compute offsets
using the original _encoded_ string.
Note that this problem only surfaces in the splitting of interpolations.
The spans to this point have already been tracked accurately. For
example, given the template ` <div></div>`, the source span for the
`div` is already correctly determined to be 6. Only when we encounter
interpolations with many parts do we run into situations where we need
to compute new spans for the individual parts of the interpolation.
atscott
force-pushed
the
encodedentitybug
branch
from
2243930 to
eae58a9
Compare
atscott
force-pushed
the
encodedentitybug
branch
from
7bfc719 to
12b6f5b
Compare
|
global presubmit (green) |
jessicajaniuk
added
the
area: compiler
|
This PR was merged into the repository by commit 2b7553d. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 8, 2022
…entities (#44811) When parsing interpolations, the input string is _decoded_ from what was in the orginal template. This means that we cannot soley rely on the input string to compute source spans because it does not necessarily reflect the exact content of the original template. Specifically, when there is an HTML entity (i.e. ` `), this will show up in its decoded form when processing the interpolation (' '). We need to compute offsets using the original _encoded_ string. Note that this problem only surfaces in the splitting of interpolations. The spans to this point have already been tracked accurately. For example, given the template ` <div></div>`, the source span for the `div` is already correctly determined to be 6. Only when we encounter interpolations with many parts do we run into situations where we need to compute new spans for the individual parts of the interpolation. PR Close #44811
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 18, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.5/13.2.6) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.5/13.2.6) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.5/13.2.6) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.5/13.2.6) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.5/13.2.6) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.5/13.2.6) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.5/13.2.6) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.5/13.2.6) | | [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.5/13.2.6) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.2.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1326-2022-03-09) [Compare Source](angular/angular@13.2.5...13.2.6) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [6efa366e2c](angular/angular@6efa366) | fix | compute correct offsets when interpolations have HTML entities ([#​44811](angular/angular#44811)) | ##### language-service | Commit | Type | Description | | -- | -- | -- | | [9bce9ce89e](angular/angular@9bce9ce) | fix | Prioritize Angular-specific completions over DOM completions ([#​45293](angular/angular#45293)) | ##### service-worker | Commit | Type | Description | | -- | -- | -- | | [cff1c5622f](angular/angular@cff1c56) | fix | file system hash in batch of 500 elements ([#​45262](angular/angular#45262)) | #### Special Thanks Andrew Scott, Anner Visser, Aristeidis Bampakos, JiaLiPassion, Joey Perrott, Kristiyan Kostadinov, Luca, Mladen Jakovljević, Paul Gschwendtner, Srikanth Kolli and nanda18 <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1211 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing interpolations, the input string is decoded from what was
in the original template. This means that we cannot solely rely on the input
string to compute source spans because it does not necessarily reflect
the exact content of the original template. Specifically, when there is
an HTML entity (i.e.
), this will show up in its decoded formwhen processing the interpolation (' '). We need to compute offsets
using the original encoded string.
Note that this problem only surfaces in the splitting of interpolations.
The spans to this point have already been tracked accurately. For
example, given the template
<div></div>, the source span for thedivis already correctly determined to be 6. Only when we encounterinterpolations with many parts do we run into situations where we need
to compute new spans for the individual parts of the interpolation.