fix(compiler-cli): ensure literal types are retained when strictNullInputTypes is disabled
#38305
+72
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
type: bug/fix
freq1: low
severity3: broken
target: patch
JoostK
force-pushed
the
ttc/literal-types
branch
from
8f06afd to
de550e1
Compare
JoostK
added
target: major
JoostK
force-pushed
the
ttc/literal-types
branch
2 times, most recently
from
525c749 to
27a83ad
Compare
JoostK
added
the
action: review
pullapprove
bot
removed
the
area: compiler
pullapprove
bot
added
the
area: compiler
JoostK
removed
the
action: review
…InputTypes` is disabled
Consider the `NgModel` directive which has the `ngModelOptions` input:
```ts
class NgModel {
@input() ngModelOptions: { updateOn: 'blur'|'change'|'submit' };
}
```
In a template this may be set using an object literal as follows:
```html
<input ngModel [ngModelOptions]="{updateOn: 'blur'}">
```
This assignment should be accepted, as the object's type aligns with the
`ngModelOptions` input in `NgModel`. However, if the `strictNullInputTypes`
option is disabled this assignment would inadvertently produce an error:
```
Type '{ updateOn: string; }' is not assignable to type '{ updateOn: "blur"|"change"|"submit"; }'.
Types of property 'updateOn' are incompatible.
Type 'string' is not assignable to type '"blur"|"change"|"submit"'
```
This is due to the `'blur'` value being inferred to be of type `string`
instead of retaining its literal type. The non-null assertion operator
that is automatically inserted for input binding assignments when
`strictNullInputTypes` is disabled inhibits TypeScript from inferring
the string value as its literal type.
This commit fixes the issue by omitting the insertion of the non-null
operator for object literals and array literals.
JoostK
force-pushed
the
ttc/literal-types
branch
from
27a83ad to
ace6a08
Compare
JoostK
added
target: patch
petebacondarwin
approved these changes
Nov 5, 2021
petebacondarwin
added
the
action: presubmit
AndrewKushnir
removed
the
action: presubmit
|
This PR was merged into the repository by commit 2a27447. |
atscott
pushed a commit
that referenced
this pull request
Nov 9, 2021
…InputTypes` is disabled (#38305) Consider the `NgModel` directive which has the `ngModelOptions` input: ```ts class NgModel { @input() ngModelOptions: { updateOn: 'blur'|'change'|'submit' }; } ``` In a template this may be set using an object literal as follows: ```html <input ngModel [ngModelOptions]="{updateOn: 'blur'}"> ``` This assignment should be accepted, as the object's type aligns with the `ngModelOptions` input in `NgModel`. However, if the `strictNullInputTypes` option is disabled this assignment would inadvertently produce an error: ``` Type '{ updateOn: string; }' is not assignable to type '{ updateOn: "blur"|"change"|"submit"; }'. Types of property 'updateOn' are incompatible. Type 'string' is not assignable to type '"blur"|"change"|"submit"' ``` This is due to the `'blur'` value being inferred to be of type `string` instead of retaining its literal type. The non-null assertion operator that is automatically inserted for input binding assignments when `strictNullInputTypes` is disabled inhibits TypeScript from inferring the string value as its literal type. This commit fixes the issue by omitting the insertion of the non-null operator for object literals and array literals. PR Close #38305
This was referenced Dec 1, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Dec 28, 2021
…InputTypes` is disabled (angular#38305) Consider the `NgModel` directive which has the `ngModelOptions` input: ```ts class NgModel { @input() ngModelOptions: { updateOn: 'blur'|'change'|'submit' }; } ``` In a template this may be set using an object literal as follows: ```html <input ngModel [ngModelOptions]="{updateOn: 'blur'}"> ``` This assignment should be accepted, as the object's type aligns with the `ngModelOptions` input in `NgModel`. However, if the `strictNullInputTypes` option is disabled this assignment would inadvertently produce an error: ``` Type '{ updateOn: string; }' is not assignable to type '{ updateOn: "blur"|"change"|"submit"; }'. Types of property 'updateOn' are incompatible. Type 'string' is not assignable to type '"blur"|"change"|"submit"' ``` This is due to the `'blur'` value being inferred to be of type `string` instead of retaining its literal type. The non-null assertion operator that is automatically inserted for input binding assignments when `strictNullInputTypes` is disabled inhibits TypeScript from inferring the string value as its literal type. This commit fixes the issue by omitting the insertion of the non-null operator for object literals and array literals. PR Close angular#38305
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the
NgModeldirective which has thengModelOptionsinput:In a template this may be set using an object literal as follows:
This assignment should be accepted, as the object's type aligns with the
ngModelOptionsinput inNgModel. However, if thestrictNullInputTypesoption is disabled this assignment would inadvertently produce an error:
This is due to the
'blur'value being inferred to be of typestringinstead of retaining its literal type. The non-null assertion operator
that is automatically inserted for input binding assignments when
strictNullInputTypesis disabled inhibits TypeScript from inferringthe string value as its literal type.
This commit fixes the issue by omitting the insertion of the non-null
operator for object literals and array literals.