-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing pipe not caught by production build with AOT #38195
Comments
Interesting, thanks for reporting. This should typically be flagged as an error, some investigation is needed to figure out why this doesn't happen here. |
@JoostK Looks like this is also the case with missing components as well |
…is disabled Even if `fullTemplateTypeCheck` is disabled should missing pipes still be reported, as was the case in View Engine. Fixes angular#38195
…is disabled Even if `fullTemplateTypeCheck` is disabled should missing pipes still be reported, as was the case in View Engine. Fixes angular#38195
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Command (mark with an
x
)Description
I have a module with a view that includes a pipe from a library.
The library was not imported into this module and thus the pipe is not included in the module.
IntelliJ correctly flags the missing pipe but the Angular build process (even when AOT is enabled) does not find this problem
The same issue occurs when referencing a pipe that doesn't even exist at all, the builder never shows any warnings or errors
The above image shows the app component including a pipe that does not exist. The pipe is highlighted red as IntelliJ recognizes the pipe has not been imported. The terminal below shows a successful production build of the project including the missing pipe. I would expect the build to fail
The example above and the repo below are both built using Nrwl NX but the same issue can be found with a regular Angular project
🔬 Minimal Reproduction
Check out the following repo: https://github.com/lukebellamy053/angular-pipe-error-example
Build either of the applications, both should fail as the pipe is either not imported or just doesn't exist but the build passes in both cases
🔥 Exception or Error
There isn't one but there should be
The text was updated successfully, but these errors were encountered: