Skip to content

Commit 23cc337

Browse files
committedApr 24, 2024
fix(@schematics/angular): keep deployUrl option when migrating to application builder
The `deployUrl` option is now supported with the new build system when using the `application` builder. The migration schematic no longer needs to remove the option if present.
1 parent 0b03829 commit 23cc337

File tree

1 file changed

+0
-22
lines changed
  • packages/schematics/angular/migrations/use-application-builder

1 file changed

+0
-22
lines changed
 

Diff for: ‎packages/schematics/angular/migrations/use-application-builder/migration.ts

-22
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ function* updateBuildTarget(
3232
buildTarget.builder = Builders.Application;
3333

3434
for (const [, options] of allTargetOptions(buildTarget, false)) {
35-
// Show warnings for using no longer supported options
36-
if (usesNoLongerSupportedOptions(options, context, projectName)) {
37-
continue;
38-
}
39-
4035
if (options['index'] === '') {
4136
options['index'] = false;
4237
}
@@ -82,7 +77,6 @@ function* updateBuildTarget(
8277
}
8378

8479
// Delete removed options
85-
delete options['deployUrl'];
8680
delete options['vendorChunk'];
8781
delete options['commonChunk'];
8882
delete options['resourcesOutputPath'];
@@ -347,19 +341,3 @@ export default function (): Rule {
347341
}),
348342
]);
349343
}
350-
351-
function usesNoLongerSupportedOptions(
352-
{ deployUrl }: Record<string, unknown>,
353-
context: SchematicContext,
354-
projectName: string,
355-
): boolean {
356-
let hasUsage = false;
357-
if (typeof deployUrl === 'string') {
358-
hasUsage = true;
359-
context.logger.warn(
360-
`Skipping migration for project "${projectName}". "deployUrl" option is not available in the application builder.`,
361-
);
362-
}
363-
364-
return hasUsage;
365-
}

0 commit comments

Comments
 (0)
Please sign in to comment.