This repository was archived by the owner on Dec 27, 2024. It is now read-only.
Check whether we can scroll vertically in the drag direction #173
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar with the internals and I'm not sure if this has side-effects, I found this problem while testing
MotionLayout
. In all the examples, scrolling up triggers a layout transition, but I noticed it is not possible to trigger a layout transition scrolling down. Looks likeMotionLayout
is always checking if we can scroll upwards, so if we scroll to the bottom of aRecyclerView
the transition will never be triggered becausetarget.canScrollVertically(-1)
will always be true.Here you can see a video with the fix:
https://github.com/dtvc87/constraintlayout/blob/drag_video/constraintlayout/device-2021-03-10-151947.webm
The red
RecylerView
pulls down the blue one and the blueRecylerView
pushes up the red one, once all its scroll is consumed.