Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting the license text in CI logs #384

Closed
tplive opened this issue Feb 20, 2023 · 2 comments
Closed

Quoting the license text in CI logs #384

tplive opened this issue Feb 20, 2023 · 2 comments

Comments

@tplive
Copy link

tplive commented Feb 20, 2023

Is it a requirement somewhere that the actual license text is quoted in the logs every single time the licenses are accepted? We have a job with 20+ parallel flavours, and this adds almost 800 lines of boilerplate in the logs, for every single flavour on every single run. Not an error, but it seems excessive and these logs go to storage and add cost.

@ViliusSutkus89
Copy link
Collaborator

Reasonable concern. That whole license agreement is 100 kb of text. However, due to legal reasons, I am not willing to hide the license text by default. We could add an optional param to the action:

- name: Setup Android SDK
  uses: android-actions/setup-android@v3
  with:
    log-android-sdk-licenses: true (default) / false

This would be pretty straightforward to implement, a perfect starter issue for a rising GitHub Actions hacker, any takers? :)

ViliusSutkus89 added a commit to ViliusSutkus89/setup-android that referenced this issue Nov 21, 2023

Verified

This commit was signed with the committer’s verified signature.
beeme1mr Michael Beemer
ViliusSutkus89 added a commit to ViliusSutkus89/setup-android that referenced this issue Nov 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ViliusSutkus89
Copy link
Collaborator

Implemented in v3.1.0. Enjoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants