chore: upload individual binaries as artifacts #3714
Merged
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
force-pushed
the
chore/upload-snapshot-artifacts
branch
4 times, most recently
from
60b86b4 to
aa8cfa4
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
chore/upload-snapshot-artifacts
branch
from
04e2887 to
6d613c9
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Mar 11, 2025
|
|
||
| - run: npm install @actions/artifact@2.2.2 | ||
|
|
||
| - uses: actions/github-script@v7 |
There was a problem hiding this comment.
why not use https://github.com/actions/upload-artifact directly as an action?
There was a problem hiding this comment.
@wagoodman the problem using upload-artifact is that you are only able to upload a single artifact -- if you give it 4 files, for example, it combines them into a single zip and uploads that. I would rather have these available for download individually so an interested party doesn't have to download all builds just to get the windows build, for example
wagoodman
approved these changes
Mar 13, 2025
kzantow
added
the
changelog-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow job that uploads the built snapshot binaries as workflow artifacts, as can be seen by following the workflow links to the summary in this PR itself.
As written, the artifacts are compressed without any intermediary folders, so downloading darwin-build_darwin_amd64_v1 is a zip file directly containing the
syftbinary, though one that is not notorized. To me, this seems more convenient than having intermediate directories likesnapshot/build_darwin_amd64_v1/syftorbuild_darwin_amd64_v1/syft.It is a separate job so it should not affect the overall workflow run times since it runs concurrently with other jobs that take longer. It only downloads the artifacts from cache, and uploads them as workflow artifacts. This seems a little odd, but there may be a performance difference in uploading to the cache vs the workflow: 4 vs ~13 seconds serially or an added ~7 seconds to
npm install @actions/artifact. It may be worth revisiting this later to simply upload the workflow artifacts and forgo the cache now that it is possible to download workflow artifacts during the same workflow, but I don't think that is necessary to accomplish the main goal of having the snapshots available for testing.Type of change