Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fluent-bit 1.7.0 dev, rc #3133

Closed
witchcraze opened this issue Aug 18, 2024 · 0 comments · Fixed by #3701
Closed

Support fluent-bit 1.7.0 dev, rc #3133

witchcraze opened this issue Aug 18, 2024 · 0 comments · Fixed by #3701
Labels
binary-analysis enhancement New feature or request good-first-issue Good for newcomers

Comments

@witchcraze
Copy link
Contributor

What would you like to be added:

Support some versions of fluent-bit in binary detection
1.7.0-dev-3 - 1.7.0-dev-9, 1.7.0-rc4 - 1.7.0-rc8 are not detected

Additional context:

OK : [NUL]1.7.0[NUL]%sFluent Bit

$ syft fluent/fluent-bit:1.7.0-dev-2 | grep fluent-bit
 ✔ Pulled image
 ✔ Loaded image                                                                                            fluent/fluent-bit:1.7.0-dev-2
 ✔ Parsed image                                                  sha256:0d62df9cad92c51a4022dbd35c5b58cc35ebd0b01904d68fd6f0ca68b6907972
 ✔ Cataloged contents                                                   30ce5b0c6dd42d8c1fa7cc5ea2a9c555b565fb4b264e6c0d7fa9242cfdaf73b5
   ├── ✔ Packages                        [11 packages]
   └── ✔ Executables                     [352 executables]
fluent-bit  1.7.0             binary

NG : [NUL]1.7.0[NUL]\x1b[1m[NUL]%sFluent Bit

$ syft fluent/fluent-bit:1.7.0-dev-3 | grep fluent-bit
 ✔ Pulled image
 ✔ Loaded image                                                                                                                                                                            fluent/fluent-bit:1.7.0-dev-3
 ✔ Parsed image                                                                                                                                  sha256:2b5323246e7e92d80b03785d5fb97039f2ed4f63a5e77957c68c4fa860570e3a
 ✔ Cataloged contents                                                                                                                                   b32f606f111a6654a8bd6468fd43012d1a05ec639a66b354a5d412563e6b60f7
   ├── ✔ Packages                        [10 packages]
   └── ✔ Executables                     [352 executables]

OK : [NUL]1.7.0[NUL]Fluent Bit

$ syft fluent/fluent-bit:1.7.0-rc3 | grep fluent-bit
 ✔ Pulled image
 ✔ Loaded image                                                                                                                                                                              fluent/fluent-bit:1.7.0-rc3
 ✔ Parsed image                                                                                                                                  sha256:f5579cc45e5be4456ba163c3e2e827c37ab76882cf3064ec353d2e0f329d2a26
 ✔ Cataloged contents                                                                                                                                   9897ad7626e818b9447a80325423cb8c8709acde9ef136bc40b5b8cffa981f5a
   ├── ✔ Packages                        [11 packages]
   └── ✔ Executables                     [352 executables]
fluent-bit  1.7.0             binary

NG : [NUL]1.7.0[NUL]\x1b[1m[NUL]%sFluent Bit

$ syft fluent/fluent-bit:1.7.0-rc4 | grep fluent-bit
 ✔ Pulled image
 ✔ Loaded image                                                                                                                                                                              fluent/fluent-bit:1.7.0-rc4
 ✔ Parsed image                                                                                                                                  sha256:a63d04b258361dabc72b3e4bbdf810255daa3195f9f462cfcbea4ba5c2c4a7d5
 ✔ Cataloged contents                                                                                                                                   db736fa27ebf5c9935575c201544f3d3d9472c2519dc30fe5e70a1b0c3328401
   ├── ✔ Packages                        [10 packages]
   └── ✔ Executables                     [352 executables]
@witchcraze witchcraze added the enhancement New feature or request label Aug 18, 2024
@wagoodman wagoodman moved this to Ready in OSS Aug 21, 2024
popey added a commit that referenced this issue Mar 2, 2025
@popey
fix: improve fluent-bit binary detection regex pattern
Loading
Loading status checks…
832d6c1 
This fixes issue #3133 by updating the regex pattern for fluent-bit binary detection
to better handle ANSI escape sequences and multiple null bytes between the version
string and "Fluent Bit" text. The change also makes the %s format specifier optional,
supporting all variations in fluent-bit binary signatures.
@popey popey mentioned this issue Mar 2, 2025
Merged
4 tasks
popey added a commit that referenced this issue Mar 2, 2025
@popey
fix: improve fluent-bit binary detection regex pattern
Loading
Loading status checks…
aa2dcf5 
This fixes issue #3133 by updating the regex pattern for fluent-bit binary detection
to better handle ANSI escape sequences and multiple null bytes between the version
string and "Fluent Bit" text. The change also makes the %s format specifier optional,
supporting all variations in fluent-bit binary signatures.

Signed-off-by: Alan Pope <alan.pope@anchore.com>
popey added a commit that referenced this issue Mar 7, 2025
@popey
test: add fluent-bit 1.7.0-dev-3 test fixture for issue #3133
Loading
Loading status checks…
fc9279b
popey added a commit that referenced this issue Mar 7, 2025
@popey
test: add fluent-bit 1.7.0-dev-3 test fixture for issue #3133
Loading
Loading status checks…
2fe1fdc 
Signed-off-by: Alan Pope <alan.pope@anchore.com>
popey added a commit that referenced this issue Mar 7, 2025
@popey
fix: improve fluent-bit binary detection regex pattern (#3701)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c687b7b 
* fix: improve fluent-bit binary detection regex pattern

This fixes issue #3133 by updating the regex pattern for fluent-bit binary detection
to better handle ANSI escape sequences and multiple null bytes between the version
string and "Fluent Bit" text. The change also makes the %s format specifier optional,
supporting all variations in fluent-bit binary signatures.

Signed-off-by: Alan Pope <alan.pope@anchore.com>

* test: add fluent-bit 1.7.0-dev-3 test fixture for issue #3133

Signed-off-by: Alan Pope <alan.pope@anchore.com>

---------

Signed-off-by: Alan Pope <alan.pope@anchore.com>
@github-project-automation github-project-automation bot moved this from Ready to Done in OSS Mar 7, 2025
@BrewTestBot BrewTestBot mentioned this issue Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary-analysis enhancement New feature or request good-first-issue Good for newcomers
Projects
OSS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve fluent-bit binary detection regex pattern anchore/syft
2 participants
@wagoodman @witchcraze