Update @types/node to Node 20
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jozef Izso <izso@cisco.com>
kzantow
reviewed
Feb 20, 2024
| @@ -0,0 +1 @@ | |||
| 20 | |||
There was a problem hiding this comment.
It allows tooling to switch to and use the correct Node runtime for the project (eg. in VS Code, Terminal, GitHub Actions).
https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/nvm
https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file
There was a problem hiding this comment.
As I understand it, the action.yml defines the node version used when it executes, does it not?
There was a problem hiding this comment.
The action.yml uses its own config to set NodeJS version.
The .nvmrc is for tooling, eg. VS Code.
kzantow
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finished changes from #440 so the types definitions are used from the Node 20 release.
Fixes #439