Make sure all chars are replaced, fix issue #396 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lts-po <philip@supernetworks.org>
|
@kzantow hey, made a new pull request. amend didn't take in the previous |
|
@lts-po do you mind if I push a quick update to fix the unrelated npm audit issue? |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
|
(I went ahead and pushed the change, happy to back it out if you don't approve) |
kzantow
approved these changes
May 3, 2023
|
Thanks for the fix @lts-po! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure all chars are replaced, fix issue #396
This should fix problems with artifact names containing invalid characters:
"Error: Artifact name is not valid: xyz-rrr:0.1.2-dev.spdx.json. Contains the following character: Colon :"
#396