Use the correct SHA for dependency snapshots from pull requests #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
approved these changes
Mar 15, 2023
|
@juxtin could you sign off the commits, though, please? |
|
Thanks @kzantow! I believe the commit is already signed off, but I admit I'm not used to doing that so perhaps I did it incorrectly? |
Evidently, `github.context.sha` is not always what you might consider the "current commit" in a given context. In most GitHub pull request event types, `github.context.sha` will be the "Last merge commit on the GITHUB_REF branch." In those cases, the commit SHA that should be associated with the snapshot is `github.event.pull_request.head.sha`. This commit adds a helper function, `getSha`, which will return the correct SHA for the current context. Signed-off-by: Justin Holguin <juxtin@github.com> Signed-off-by: GitHub <noreply@github.com>
juxtin
force-pushed
the
fix-sha-on-pr-events
branch
from
2937f5e
to
b2cf607
Compare
|
I tried again, for some reason it expected it to be signed off by GitHub as well as by me personally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢馃徑 from the Dependency Graph team at GitHub!
I've been working on some functionality related to dependency snapshots on pull requests, and I've discovered an unfortunate fact about the behavior of
github.context.sha/$GITHUB_SHAin that context.Evidently,
github.context.shais not always what you might consider the "current commit" in a given context. In most GitHub pull request event types,github.context.shawill be the "Last merge commit on the GITHUB_REF branch" (See Actions documentation here). In those cases, the commit SHA that should be associated with the snapshot isgithub.event.pull_request.head.sha.This PR adds a helper function,
getSha, which will return the correct SHA for the current context, and uses that function to find the right SHA to add to the dependency snapshot.