Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added support of workflow artifact's retention policy #398

Merged
merged 13 commits into from Mar 20, 2023

Conversation

ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Mar 6, 2023

  • added new input to support retention of workflow artifact
  • updated Action Vampire/setup-wsl to v2
  • added missed inputs in readme
  • updated dependency http-cache-semantics to 4.1.1 (GHSA-rc47-6667-2j5j)
  • added unit tests for new input

ViacheslavKudinov and others added 4 commits March 2, 2023 16:22
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
@ViacheslavKudinov
Copy link
Contributor Author

Hi @kzantow
could you, please, take a look when you have a time?

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to see some actual testing added for this

action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ViacheslavKudinov
Copy link
Contributor Author

It would be nice to see some actual testing added for this

Yes, it makes sense. But it will take some time as I'm not a TS developer and need to improve my skills to write proper testing there.
I will give a try.
Thanks @kzantow for comments.

@kzantow
Copy link
Contributor

kzantow commented Mar 13, 2023

@ViacheslavKudinov I think if you just wanted to update the uploadArtifact mock here to have the updated signature being used, you could maybe just use the execArgs -- the uploadArtifact mock you could just change to something like:

              uploadArtifact(name: string, file: string, rootDirectory: string, options: any) {
                data.execArgs.env = options
                data.artifacts.push({
                  name: path.basename(name),
                  file,
                } as never);
              },

And then in the test check data.execArgs.env, something like this

@ViacheslavKudinov ViacheslavKudinov marked this pull request as draft March 15, 2023 15:46
ViacheslavKudinov and others added 8 commits March 15, 2023 16:55
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VKMacBookM1Pro.local>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
…-input-tuning

Updated retention related input and TS code
@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review March 18, 2023 21:37
@ViacheslavKudinov ViacheslavKudinov changed the title [FEATURE] Added support of artifact's retention policy [FEATURE] Added support of workflow artifact's retention policy Mar 18, 2023
@kzantow
Copy link
Contributor

kzantow commented Mar 19, 2023

@ViacheslavKudinov do you mind if I push a few tweaks to this?

@ViacheslavKudinov
Copy link
Contributor Author

@ViacheslavKudinov do you mind if I push a few tweaks to this?

Sure, thanks!

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the contribution @ViacheslavKudinov

@kzantow kzantow merged commit 448520c into anchore:main Mar 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants