Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): overwrite files array when setting up Vitest #1646

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #1645

What is the new behavior?

When running the schematic to setup Vitest or migrate to Analog w/Vitest, the files array in the tsconfig.spec.json is set to the new src/test-setup.ts file.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Sorry, something went wrong.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 86c6c50
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67d3a8d0cd7a8f00088b3fe6
😎 Deploy Preview https://deploy-preview-1646--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 86c6c50
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/67d3a8d0ede3570007e2b660
😎 Deploy Preview https://deploy-preview-1646--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 86c6c50
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67d3a8d0927e000008ecdc3a
😎 Deploy Preview https://deploy-preview-1646--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 86c6c50
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67d3a8d0c7222f0008caae91
😎 Deploy Preview https://deploy-preview-1646--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 17f5c65 into beta Mar 14, 2025
24 checks passed
@brandonroberts brandonroberts deleted the fix-tsconfig-spec-file branch March 14, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running setup-vitest script is missing a change required in tsconfig.spec.json
1 participant