Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest-angular): add check for nx inside generator #1635

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

luishcastroc
Copy link
Contributor

  • Add check for Nx version inside the setup-vitest generator to add proper dependencies.
  • Add test for the generator

PR Checklist

Closes #1630

What is the new behavior?

generator adds Vite 5/Vitest 3 if Nx version is prior to 20.5

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Sorry, something went wrong.

…vite dependency and add test
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 68a9ed9
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67c9c06d8d18180008507b4c
😎 Deploy Preview https://deploy-preview-1635--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 68a9ed9
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67c9c06dc4f52100083e5f93
😎 Deploy Preview https://deploy-preview-1635--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 68a9ed9
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67c9c06dbdc1a9000929caff
😎 Deploy Preview https://deploy-preview-1635--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 68a9ed9
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/67c9c06d7822b90008439555
😎 Deploy Preview https://deploy-preview-1635--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brandonroberts brandonroberts merged commit 9db028c into analogjs:beta Mar 6, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version conflicts on vitest
2 participants