Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered #36160

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

kelvinbiffi
Copy link

@kelvinbiffi kelvinbiffi commented Sep 24, 2021

The feature on this PR is to be able to create a data vars slot id by unit when data-slot is entered

I believe this feature is important to know the quantity os ad unit types have in one page on analytics trigger

psc @gurodrigues

@kelvinbiffi
Copy link
Author

Hi @lannka
I implemented a simple feature to be able to identify the index of the amp-ad by slot units, could you have a look? =)

@kelvinbiffi
Copy link
Author

Hi @lannka ,

Did you get a look?

Is there anything I need to do?

@calebcordry

@alanorozco alanorozco requested review from calebcordry and removed request for lannka October 7, 2021 00:20
@alanorozco
Copy link
Member

@ampproject/wg-monetization

extensions/amp-ad/0.1/amp-ad.js Outdated Show resolved Hide resolved
extensions/amp-ad/0.1/amp-ad.js Outdated Show resolved Hide resolved
@kelvinbiffi
Copy link
Author

Hi @powerivq

I made the changes you pointed, and I tried to create a 'macro' in amp-analytics consuming that attribute, however, I couldn't find a way to make it work correctly

Could you give me a clue about how could I create that macro?

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kelvinbiffi
✅ EdmilsonSilva
❌ Edmilson


Edmilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants