Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative URL used in AMP4email example code #6776

Open
M-J-Robbins opened this issue Mar 1, 2024 · 2 comments
Open

Relative URL used in AMP4email example code #6776

M-J-Robbins opened this issue Mar 1, 2024 · 2 comments
Labels
Status: Pending Triage Type: Bug

Comments

@M-J-Robbins
Copy link

馃悰 Bug Report

Current behavior

The code in the Advanced Server Request example uses a relative URL which is not valid in AMP4Email and shows an error when viewed in the playground.

Error message: The relative URL '/static/inline-examples/data/amp-list-animals.json' for attribute 'src' in tag 'amp-list' is disallowed.

Code in GitHub

Expected behavior/code

Expect example code to pass validation

Reproduction procedure

  1. Open Advanced Server Request example the in playground
  2. Look at error message
@dkjonzy2
Copy link
Contributor

dkjonzy2 commented Mar 1, 2024

Fix is to add "https://amp.dev" to the beginning of the url so that the full url is "https://amp.dev/static/inline-examples/data/amp-list-animals.json"

I'll submit a PR

@dkjonzy2
Copy link
Contributor

dkjonzy2 commented Mar 1, 2024

PR here waiting review #6778

@erwinmombay erwinmombay mentioned this issue Mar 6, 2024
Merged
erwinmombay pushed a commit that referenced this issue Mar 6, 2024
@dkjonzy2
Fix Issue #6776 "Relative URL used in AMP4email example code" (#6778)
03710a3 
* Add zaymo tool

* move to bottom

* Fix relative url in broken amp email example - "Advanced Server Request"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Triage Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@M-J-Robbins @dkjonzy2