Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solaris support #92

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add Solaris support #92

merged 1 commit into from
Nov 28, 2024

Conversation

kulikjak
Copy link
Contributor

Hi, when trying to build sigstore on Solaris, I've hit an issue with webbrowser-rs not supporting it (as it needs the home crate). This minor change solves that issue.

Tests are green:

running 5 tests
test test_open_chrome ... ignored
test test_open_firefox ... ignored
test test_open_safari ... ignored
test test_open_webpositive ... ignored
test os::tests_xdg::test_xdg_open_local_file ... ok

test result: ok. 1 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 1.01s

     Running tests/common.rs (target/debug/deps/common-368bc0ade2ab6989)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_android.rs (target/debug/deps/test_android-bae4723d08ac0efc)

running 3 tests
test tests::test_android ... ignored
test tests::test_non_existence_safari ... ok
test tests::test_existence_default ... ok

test result: ok. 2 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.32s

     Running tests/test_ios.rs (target/debug/deps/test_ios-33d0202a2a5f4b1a)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_macos.rs (target/debug/deps/test_macos-b7ccf04782123dd3)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_unix.rs (target/debug/deps/test_unix-67ee6936302778a0)

running 6 tests
test tests::test_non_existence_safari ... ok
test tests::test_existence_default ... ok
test tests::test_local_file_abs_path ... ok
test tests::test_local_file_uri ... ok
test tests::test_local_file_rel_path ... ok
test tests::test_open_default ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 28.11s

     Running tests/test_wasm.rs (target/debug/deps/test_wasm-17a823806d32e01b)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_windows.rs (target/debug/deps/test_windows-2aa956fe49cdf6c8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests webbrowser

running 5 tests
test src/lib.rs - open (line 253) - compile ... ok
test src/lib.rs - open (line 260) - compile ... ok
test src/lib.rs - (line 7) - compile ... ok
test src/lib.rs - open_browser (line 275) - compile ... ok
test src/lib.rs - open_browser_with_options (line 293) - compile ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.13s

@amodm amodm merged commit 26aaeee into amodm:main Nov 28, 2024
@amodm
Copy link
Owner

amodm commented Nov 28, 2024

Thanks for helping expand the platform coverage. And also for the test report.

@amodm
Copy link
Owner

amodm commented Nov 28, 2024

This is now out as v1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants