Bail from try_xdg
if browser name is empty
#64
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, not sure if I'm horribly off the mark. Had an infinite loop in WSL with the following on main branch:
There was apparently no default for browser in xdg settings:

This causes an infinite loop because
open_using_xdg_config
ends up opening a directory and rust-lang/rust#64144?Fixed it by simply bailing if there is no name.