Pass locale info through to vl-convert, default to display embed options when not set #3274
+150
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes related to locale handling:
it-IT
) rather than only by setting the full locale dictionary.alt.renderers.set_embed_options
(if any). This way you can callalt.renderers.set_embed_options
once and all of the charts will be displayed and saved using the provided locale configuration.Still needs documentation, but I haven't decided whether to tackle that in this PR or not. If folks have ideas for where best to document this functionality let me know!
cc @MarcoBaroncini