Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update require: rubocop-x to plugins: rubocop-x #468

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

colinbruce
Copy link
Contributor

This removes the migration warnings when running rubocop

⚠️ Make sure you release a new version of this gem after merging your changes. ⚠️

Refer to the existing docs if you are making changes to the supported Ruby versions.

This removes the migration warnings when running rubocop
@colinbruce
Copy link
Contributor Author

I'm aware this won't get merged direct, but it aims to reduce the noise when running the new version of the rubocop-govuk gem

Inspecting 173 files
.............................................................................................................................................................................

173 files inspected, no offenses detected
rubocop-rake extension supports plugin, specify `plugins: rubocop-rake` instead of `require: rubocop-rake` in /gems/rubocop-govuk-5.0.9/config/rake.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

rubocop-rails extension supports plugin, specify `plugins: rubocop-rails` instead of `require: rubocop-rails` in /gems/ruby-3.4.1/gems/rubocop-govuk-5.0.9/config/rails.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

rubocop-rspec extension supports plugin, specify `plugins: rubocop-rspec` instead of `require: rubocop-rspec` in /gems/ruby-3.4.1/gems/rubocop-govuk-5.0.9/config/rspec.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

@agoldstone93
Copy link

@colinbruce Came here to do the same thing. I'm also getting the following:

rubocop-capybara extension supports plugin, specify `plugins: rubocop-capybara` instead of `require: rubocop-capybara` in /Users/adam.goldstone/.rvm/gems/ruby-3.4.1/gems/rubocop-govuk-5.0.10/config/capybara.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

Can the same be done for capybara too as part of this PR?

@colinbruce
Copy link
Contributor Author

@colinbruce Came here to do the same thing. I'm also getting the following:

rubocop-capybara extension supports plugin, specify `plugins: rubocop-capybara` instead of `require: rubocop-capybara` in /Users/adam.goldstone/.rvm/gems/ruby-3.4.1/gems/rubocop-govuk-5.0.10/config/capybara.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

Can the same be done for capybara too as part of this PR?

It can now

When I opened the PR, the rubocop-capybara gem had not been converted to plugin status... I'll get it added

Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for raising the PR. We will get it merged and will release a new version shortly

@jasonBirchall jasonBirchall merged commit 31a70e8 into alphagov:main Mar 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants